Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions workflow to check typos for PR #67

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

weishan18
Copy link
Contributor

@weishan18 weishan18 commented Oct 8, 2024

Solving issue #61

Description
Introduce a new GitHub Actions workflow to check typos using https://github.com/crate-ci/typos to prevent such mistakes from PR checks

Changes
Added typos.yml

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2024

CLA assistant check
All committers have signed the CLA.

@moreal
Copy link
Contributor

moreal commented Oct 8, 2024

@weishan18 Thanks for your first contribution! Could you sign our CLA?


Also we're now operating Modathon 2024 (Nine Chronicles Hackathon) with a prize pool about $10,000. If you're interested, please take a look at the following items 🙏🏻
https://dorahacks.io/hackathon/planetarium-2024modathon/detail
https://planetarium.dev/discord

@moreal moreal linked an issue Oct 8, 2024 that may be closed by this pull request
@moreal moreal self-requested a review October 8, 2024 06:30
.github/workflows/typos.yaml Outdated Show resolved Hide resolved
.github/workflows/typos.yaml Outdated Show resolved Hide resolved
.github/workflows/typos.yaml Outdated Show resolved Hide resolved
@weishan18
Copy link
Contributor Author

Updated with the suggestions

Copy link
Contributor

@moreal moreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying them! 🙏🏻 The check now fails because there are some typos. Do you want to fix them too? Or you can leave it as a new issue. (I'll open a new issue if you want to merge this pull request at this step)

@weishan18
Copy link
Contributor Author

Hi, noticed that the typo check has failed, should I proceed to fix the typos detected?
image

@weishan18
Copy link
Contributor Author

Alright, I just saw your comments, is it possible to open a new issue? And i'll fix the typos in the new issue, thank you!

@moreal moreal merged commit fc6bdcc into planetarium:main Oct 8, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a new GitHub Actions workflow to check typos
3 participants